----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/#review12192 -----------------------------------------------------------
branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22243> Extraneous white space branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22244> Given how tricky it is to set up TLS support, I'd go ahead and add an off nominal handler for BIO_new_file here. Something like: if (bio != NULL) { ... } else { ast_log(LOG_WARNING, "Failed to open private key file %s: %s(%d)\n", cfg->pvtfile, strerror(errno), errno); } branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22245> I'd stay away from ast_verb(0, ...). It implies that the system administrator's preferences should be completely ignored. I'd use ast_verb(1, ...) for important initialization statements, and ast_verb(2, ...) for useful but not strictly important success messages. branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22246> Extraneous white space here as well branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22248> I'd use ast_verb(2, ...) for this branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22247> I'd use ast_verb(2, ...) for this branches/12/main/tcptls.c <https://reviewboard.asterisk.org/r/3647/#comment22249> FYI: this is not a good example of an Asterisk verbose message :-( - Matt Jordan On June 19, 2014, 8:42 a.m., Alexander Traud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3647/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 8:42 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23905 > https://issues.asterisk.org/jira/browse/ASTERISK-23905 > > > Repository: Asterisk > > > Description > ------- > > see Bugs > > > Diffs > ----- > > branches/12/main/tcptls.c 411465 > > Diff: https://reviewboard.asterisk.org/r/3647/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Traud > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
