----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3650/#review12201 -----------------------------------------------------------
/trunk/pbx/pbx_config.c <https://reviewboard.asterisk.org/r/3650/#comment22255> I recommend using ast_strdupa() for the exten instead of ast_strdup() here. /trunk/pbx/pbx_config.c <https://reviewboard.asterisk.org/r/3650/#comment22259> Add braces to this if statement. /trunk/pbx/pbx_config.c <https://reviewboard.asterisk.org/r/3650/#comment22258> I recommend replacing this with a bit simpler code: else if (sscanf(c, "%d", &ipriority) != 1) { astman_send_error(...); return 0; } /trunk/pbx/pbx_config.c <https://reviewboard.asterisk.org/r/3650/#comment22261> You can combine these two lines: } else if (...) { /trunk/pbx/pbx_config.c <https://reviewboard.asterisk.org/r/3650/#comment22262> I recommend ast_strdupa() here as well. - Mark Michelson On June 19, 2014, 4:41 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3650/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 4:41 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: Asterisk > > > Description > ------- > > Adds 'DialplanAddExtension' and 'DialplanRemoveExtension' manager commands > that work in mostly the same way as their CLI command equivalents. The > following header arguments are used for each: > > Action: DialplanAddExtension > Context - which context should be used > Extension - name of the extension being created, if '/' is included, the > portion after the '/' is a CID match for that extension. > Priority - priority being added > Application - name of the application to be used at this priority > ApplicationData - not required (if not included results in no args), forms > the arguments to the application > Replace - not required (if not included, same as 'no'). If set to a truth > value, replace existing extensions/priorities rather than failing if one > exists where we are adding already. > > Action: DialplanRemoveExtension > Context - which context is being removed from > Extension - Which extension is being removed or having a priority removed > from, if '/' is included, the portion after the '/' is a CID match for that > extension. > Priority - not required, if included then just a single priority is removed > from the extension instead of the whole extension. > > > Diffs > ----- > > /trunk/pbx/pbx_config.c 416234 > /trunk/main/pbx.c 416234 > /trunk/CHANGES 416234 > > Diff: https://reviewboard.asterisk.org/r/3650/diff/ > > > Testing > ------- > > Tested add extension with/without appdata > Tested add extension with/without '/' in extension and made sure the rest of > the field was used as a CID value and that it worked the same as the CLI > command equivalent > Tested remove extension with/without priority > Tested remove extension with/without '/' in extension and made sure that if > CID was included that it deleted the CID including extension. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
