> On June 24, 2014, 9:16 a.m., Matt Jordan wrote: > > /team/group/media_formats-reviewed-trunk/main/codec_builtin.c, lines 706-710 > > <https://reviewboard.asterisk.org/r/3667/diff/2/?file=60526#file60526line706> > > > > Good catch on this. I missed that ast_codec_register creates the codec > > object that should be used.
Well actually REF_DEBUG caught it. Running asterisk with 0 modules made it easy to see the unbalanced refs. - Corey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3667/#review12289 ----------------------------------------------------------- On June 24, 2014, 3:39 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3667/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 3:39 a.m.) > > > Review request for Asterisk Developers, Joshua Colp and Matt Jordan. > > > Repository: Asterisk > > > Description > ------- > > These are changes required to get the trunk branch to build. > > Modules still be broken and not touched: res_rtp_asterisk, res_format_attr_*, > test_format_api. > > > Diffs > ----- > > /team/group/media_formats-reviewed-trunk/tests/test_voicemail_api.c 417166 > /team/group/media_formats-reviewed-trunk/tests/test_format_cap.c 417166 > /team/group/media_formats-reviewed-trunk/tests/test_abstract_jb.c 417166 > /team/group/media_formats-reviewed-trunk/res/res_rtp_multicast.c 417166 > /team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 417166 > /team/group/media_formats-reviewed-trunk/res/res_musiconhold.c 417166 > /team/group/media_formats-reviewed-trunk/res/res_fax_spandsp.c 417166 > /team/group/media_formats-reviewed-trunk/main/manager.c 417166 > /team/group/media_formats-reviewed-trunk/main/codec_builtin.c 417166 > /team/group/media_formats-reviewed-trunk/main/cli.c 417166 > /team/group/media_formats-reviewed-trunk/main/channel.c 417166 > /team/group/media_formats-reviewed-trunk/funcs/func_talkdetect.c 417166 > > Diff: https://reviewboard.asterisk.org/r/3667/diff/ > > > Testing > ------- > > Compiled > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
