> On June 27, 2014, 8 a.m., Matt Jordan wrote: > > I'm not sure why this feature is necessary. > > > > Using pre-dial, feature codes (via FEATUREMAP) can be set on either an > > inbound or an outbound channel prior to dialling. The fact that this > > channel data store is not always inherited means we will be propagating > > additional inheritance options out to the dialplan to 'enable' inheritance > > on the features, which feels like a step backwards when there is already > > another mechanism to properly put what you want on the channel when you > > want it on the channel.
You make a good point. I occasionally forget that pre-dial handlers exist and using a datastore's built-in inheritance seemed like the "right" way to go at the time. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3684/#review12369 ----------------------------------------------------------- On June 26, 2014, 2:32 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3684/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 2:32 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change allows channel-stored feature hooks to be inherited from parent > channel to child channel in the same way that datastores are inherited. > > > Diffs > ----- > > trunk/tests/test_channel_feature_hooks.c 417361 > trunk/main/channel.c 417361 > trunk/include/asterisk/channel.h 417361 > > Diff: https://reviewboard.asterisk.org/r/3684/diff/ > > > Testing > ------- > > Tested manually and ran the unit test in this review. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
