-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3703/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-23957
https://issues.asterisk.org/jira/browse/ASTERISK-23957
Repository: Asterisk
Description
-------
This change does a few things:
1. Fixes an issue where direct format interfaces were treated as AO2 objects
when they were not.
2. Added an ast_format_clone API call which clones and deep copies a format,
returning one which can be safely modified.
3. Changed the format interface API so anything which manipulates the format
returns a new format.
4. Added get/set functions for format attribute data.
5. Added an API call to replace the format in an RTP engine codecs structure.
6. Updated the res_format_attr_* modules to work with the new media formats
work.
7. Added support for loading an interface module after a format has been
created.
Diffs
-----
/team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 417762
/team/group/media_formats-reviewed-trunk/res/res_format_attr_silk.c 417762
/team/group/media_formats-reviewed-trunk/res/res_format_attr_opus.c 417762
/team/group/media_formats-reviewed-trunk/res/res_format_attr_h264.c 417762
/team/group/media_formats-reviewed-trunk/res/res_format_attr_h263.c 417762
/team/group/media_formats-reviewed-trunk/res/res_format_attr_celt.c 417762
/team/group/media_formats-reviewed-trunk/main/rtp_engine.c 417762
/team/group/media_formats-reviewed-trunk/main/format.c 417762
/team/group/media_formats-reviewed-trunk/include/asterisk/rtp_engine.h 417762
/team/group/media_formats-reviewed-trunk/include/asterisk/format.h 417762
/team/group/media_formats-reviewed-trunk/channels/chan_sip.c 417762
Diff: https://reviewboard.asterisk.org/r/3703/diff/
Testing
-------
Placed calls in and out, confirmed that the attribute stuff doesn't crash
things and that received SDP is parsed and interpreted. What doesn't currently
work is passing this information through so outgoing calls have the correct
attributes.
Thanks,
Joshua Colp
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
