> On July 4, 2014, 7:48 a.m., Alexander Traud wrote:
> > As I am the contributor of the original patch: Argg, I thought I
> > double-checked all symbols. Anyway, mistakes happen.
> > I am not sure why I wasn’t invited as reviewer for this one here.
> >
> > EC_KEY_new_by_curve_name() is the only culprit symbol, or? The first part
> > of my patch is not related to Elliptic Curve (ECDHE). Therefore, DHE is not
> > affected and should not be stripped. Consequently, the here introduced
> > #ifdef HAVE_OPENSSL_EC should come later. I would have placed just before
> > that last } else { to disable just that condition. That way, ECDHE kicks in
> > automatically even without a re-compile, when the underlying OpenSSL
> > library is changed to version 1.0.2.
> >
> > As I am new here, do I have to open a review with a patch attached, or how
> > do we handle this?
Quickest is if you open your own request. Mortals do not have the power to
change other people's requests. And exchanging patches over RB is not common.
Oh, I see that it has been submitted already. In that case: open your own
request.
- wdoekes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3709/#review12483
-----------------------------------------------------------
On July 3, 2014, 4:55 p.m., Matt Jordan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3709/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 4:55 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-23905
> https://issues.asterisk.org/jira/browse/ASTERISK-23905
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Review https://reviewboard.asterisk.org/r/3647/ introduced PFS in Asterisk
> that depends on the elliptic curve library support being present in OpenSSL.
> As it turns out, some versions of OpenSSL don't have this library - notably
> the version running on our build agents.
>
> This patch fixes the build by providing a configure check for the specific
> library calls that the PFS patch relies on.
>
>
> Diffs
> -----
>
> /trunk/main/tcptls.c 417876
> /trunk/include/asterisk/autoconfig.h.in 417876
> /trunk/configure.ac 417876
> /trunk/configure UNKNOWN
>
> Diff: https://reviewboard.asterisk.org/r/3709/diff/
>
>
> Testing
> -------
>
> With ec.h present, Asterisk detects the header via the presence of the
> specified function and sets HAVE_OPENSSL_EC to 1.
>
> Without ec.h present, Asterisk does not detect the file. HAVE_OPENSSL_EC is
> 0, and the build succeeds.
>
>
> Thanks,
>
> Matt Jordan
>
>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
