-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3710/
-----------------------------------------------------------
(Updated July 4, 2014, 7:45 a.m.)
Review request for Asterisk Developers.
Changes
-------
Check if local_peer is NULL before subscribing to it
Bugs: ASTERISK-23939
https://issues.asterisk.org/jira/browse/ASTERISK-23939
Repository: Asterisk
Description
-------
This patch fixes two bugs:
(1) When originating a channel into a Stasis application, we already create a
subscription for the channel that is going into our Stasis app. Unfortunately,
when you create a Local channel and pass it off to a Stasis app, you really
aren't creating just one channel: you're creating two. This patch snags the
second half of the Local channel pair (assuming it is a Local channel pair, but
luckily core_local is kind about such assumptions) and subscribes to it as well.
(2) Subscriptions are a bit sticky right now. If a subscription is made, the
'interest' count gets bumped on the Stasis subscription - but unless something
explicitly unsubscribes the channel, said subscription sticks around. This is
not much of a problem is a user is creating the subscription - if they made it,
they must want it. However, when we are creating implicit subscriptions, we
need to make sure something clears them out. This patch takes a pessimistic
approach: it watches the cache updates coming from Stasis and, if we notice
that the cache just cleared out an object, we delete our subscription object.
This keeps our ao2 container of Stasis forwards in an application from growing
out of hand; it also is a bit more forgiving for end users who may not realize
they were supposed to unsubscribe from that channel that just hung up.
Diffs (updated)
-----
/branches/12/res/stasis/app.c 417955
/branches/12/res/res_stasis.c 417955
/branches/12/res/ari/resource_channels.c 417955
/branches/12/include/asterisk/stasis_app.h 417955
Diff: https://reviewboard.asterisk.org/r/3710/diff/
Testing
-------
The channels originate test (which makes 25 Local channels) now gets 25
channels in its Stasis application, but gets 50 destruction messages.
Inspection of the log file shows that it also gets the dialplan execution
messages for the Local channel halves off executing dialplan.
Thanks,
Matt Jordan
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
