> On July 4, 2014, 3:43 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_dialog_info_body_generator.c, lines 152-155 > > <https://reviewboard.asterisk.org/r/3705/diff/1/?file=62059#file62059line152> > > > > Doxygen comments on these #defines would be nice, as they aren't > > 'obvious' sizes (3? 39?)
I'll admit I shamelessly stole these from Mark. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/#review12492 ----------------------------------------------------------- On July 2, 2014, 8:57 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3705/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 8:57 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-21443 > https://issues.asterisk.org/jira/browse/ASTERISK-21443 > > > Repository: Asterisk > > > Description > ------- > > This change does the following: > > 1. Provides the underlying subscription to body generators for extension > state by placing it in the data structure. > 2. Makes the ast_sip_presence_xml_create_node function optionally add the > created node to a parent node. > 3. Adds dialog as a supported event to res_pjsip_exten_state. > 4. Adds a res_pjsip_dialog_info_body_generator module for generating the > dialog-info+xml body for NOTIFY messages. > > > Diffs > ----- > > /branches/12/res/res_pjsip_exten_state.c 417756 > /branches/12/res/res_pjsip_dialog_info_body_generator.c PRE-CREATION > /branches/12/res/res_pjsip/presence_xml.c 417756 > /branches/12/include/asterisk/res_pjsip_presence_xml.h 417756 > /branches/12/include/asterisk/res_pjsip_body_generator_types.h 417756 > > Diff: https://reviewboard.asterisk.org/r/3705/diff/ > > > Testing > ------- > > Used a Grandstream phone to subscribe and watched NOTIFY messages go to it as > I did things. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
