----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3713/#review12497 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On July 4, 2014, 3:49 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3713/ > ----------------------------------------------------------- > > (Updated July 4, 2014, 3:49 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > I missed a couple issues on r3689: > * chan_mgcp: buf unused variable prevents devmode build > * chan_skinny / chan_unistim: tech.capabilities double ao2_cleanup > * format_cap: ao2_ref(framed, +1) was mistakenly removed, causing many fracks > > In the case of format_cap, I didn't notice that it was being added to a > cap->formats and caps->preference_order. > > > Diffs > ----- > > /team/group/media_formats-reviewed-trunk/main/format_cap.c 418064 > /team/group/media_formats-reviewed-trunk/channels/chan_unistim.c 418064 > /team/group/media_formats-reviewed-trunk/channels/chan_skinny.c 418064 > /team/group/media_formats-reviewed-trunk/channels/chan_mgcp.c 418064 > > Diff: https://reviewboard.asterisk.org/r/3713/diff/ > > > Testing > ------- > > Compile, run, shutdown gracefully with no fracks. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
