-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3738/
-----------------------------------------------------------
(Updated July 10, 2014, 1:06 p.m.)
Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt
Jordan.
Changes
-------
Include the removal of ao2_bump from codecs as Corey suggested.
Bugs: ASTERISK-23960
https://issues.asterisk.org/jira/browse/ASTERISK-23960
Repository: Asterisk
Description
-------
The format on the frame was being unreffed on static frames that had not bumped
the ref resulting in a crash when compiled with the DO_CRASH flag due to the
refcount on the format going negative.
Diffs (updated)
-----
team/group/media_formats-reviewed-trunk/main/frame.c 418253
team/group/media_formats-reviewed-trunk/include/asterisk/slin.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_ulaw.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_speex.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_lpc10.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_ilbc.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_gsm.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_g726.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_g722.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_alaw.h 418253
team/group/media_formats-reviewed-trunk/codecs/ex_adpcm.h 418253
Diff: https://reviewboard.asterisk.org/r/3738/diff/
Testing
-------
Ensured that the crash was resolved.
Thanks,
opticron
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
