----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3745/#review12628 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On July 14, 2014, 11:48 a.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3745/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 11:48 a.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Bugs: ASTERISK-23911 > https://issues.asterisk.org/jira/browse/ASTERISK-23911 > > > Repository: Asterisk > > > Description > ------- > > WARNING[4943]: func_uri.c:79 uriencode: Syntax: URIENCODE(<data>) - missing > argument! > > There is nothing especially wrong with trying to encode an empty string, so > there is no need to warn for it. > Plus avoiding the warning requires making some dialplans more elaborate. > This: > > same => n,Stasis(myapp,${URIENCODE(${ARGS})) > > becomes this: > > same => n,GotoIf($[${LEN(${ARGS})} = 0]skip:) > same => n,Set(ARGS=${URIENCODE(${ARGS})}) > same => n(skip),NoOp() > same => n,Stasis(MyApp,${ARGS}) > > for instance. > > > Diffs > ----- > > /branches/1.8/funcs/func_uri.c 418366 > > Diff: https://reviewboard.asterisk.org/r/3745/diff/ > > > Testing > ------- > > Checked to make sure the warning doesn't get generated anymore. It doesn't. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
