> On July 14, 2014, 4:30 p.m., Corey Farrell wrote: > > Shouldn't this add to CHANGES? I being this up mostly due to the new > > required external dependency.
Yes, it should, and the new dependency should be in the UPGRADE notes. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3773/#review12636 ----------------------------------------------------------- On July 14, 2014, 4:21 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3773/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 4:21 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-20703 > https://issues.asterisk.org/jira/browse/ASTERISK-20703 > > > Repository: Asterisk > > > Description > ------- > > This patch removes menuselect as a subversion external repo and adds it > directly to the Asterisk source. This makes Asterisk substantially more git > friendly. > > Asterisk is (I think) the only thing that uses menuselect still, as such, > keeping menuselect in a separate repository isn't strictly necessary any > longer. This patch also goes ahead and makes mxml a required library, > removing the need for the mxml repo. > > Changes to menuselect were kept at a minimum - however, I opted to copy and > add the source files directly rather than attempting any particular svn > operation. That does mean we would lose the menuselect history for trunk (13) > onwards. I'm not sure how big of a loss that is, given the relative > infrequency with which changes are made (and the menuselect history isn't > gone, just disconnected...) > > The only functional change with this patch: the menuselect UI is no longer > run automatically the first time around. I'm not sure how needed (or desired) > that is, since make menuselect is always available to configure settings. > > Note that menuselect/mxml will continue to exist as separate repos for > existing Asterisk branches. We can always choose to backport this patch at > some future time to other branches, if the need arises. > > > Diffs > ----- > > /trunk/menuselect/test/menuselect-tree PRE-CREATION > /trunk/menuselect/test/build_tools/menuselect-deps PRE-CREATION > /trunk/menuselect/strcompat.c PRE-CREATION > /trunk/menuselect/missing PRE-CREATION > /trunk/menuselect/menuselect_stub.c PRE-CREATION > /trunk/menuselect/menuselect_newt.c PRE-CREATION > /trunk/menuselect/menuselect_gtk.c PRE-CREATION > /trunk/menuselect/menuselect_curses.c PRE-CREATION > /trunk/menuselect/menuselect.c PRE-CREATION > /trunk/menuselect/menuselect.h PRE-CREATION > /trunk/menuselect/makeopts.in PRE-CREATION > /trunk/menuselect/makeopts PRE-CREATION > /trunk/menuselect/make_version PRE-CREATION > /trunk/menuselect/linkedlists.h PRE-CREATION > /trunk/menuselect/install-sh PRE-CREATION > /trunk/menuselect/example_menuselect-tree PRE-CREATION > /trunk/menuselect/contrib/menuselect-dummy PRE-CREATION > /trunk/menuselect/contrib/Makefile-dummy PRE-CREATION > /trunk/menuselect/configure.ac PRE-CREATION > /trunk/menuselect/configure PRE-CREATION > /trunk/menuselect/config.sub PRE-CREATION > /trunk/menuselect/config.log PRE-CREATION > /trunk/menuselect/config.guess PRE-CREATION > /trunk/menuselect/bootstrap.sh PRE-CREATION > /trunk/menuselect/autoconfig.h.in PRE-CREATION > /trunk/menuselect/autoconfig.h PRE-CREATION > /trunk/menuselect/aclocal.m4 PRE-CREATION > /trunk/menuselect/acinclude.m4 PRE-CREATION > /trunk/menuselect/README PRE-CREATION > /trunk/menuselect/Makefile PRE-CREATION > /trunk/include/asterisk/autoconfig.h.in 418565 > /trunk/configure.ac 418565 > /trunk/configure UNKNOWN > > Diff: https://reviewboard.asterisk.org/r/3773/diff/ > > > Testing > ------- > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
