> On July 9, 2014, 8:54 a.m., opticron wrote:
> > /trunk/res/res_fax.c, line 3962
> > <https://reviewboard.asterisk.org/r/3666/diff/4/?file=62243#file62243line3962>
> >
> >     Why do these commands send a global event after sending an ack instead 
> > of replying in the ack?
> 
> opticron wrote:
>     They're not global, but the question still stands.

After further review, this only appears to be possible if the code exists 
inside manager.c. Feel free to ignore this.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3666/#review12518
-----------------------------------------------------------


On July 3, 2014, 2:38 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3666/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 2:38 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> More CLI to AMI command conversions, this time focusing on everyone's 
> favorite method for sending documents, FAX!
> 
> FAXSessions replicates the functionality of fax show sessions, and is more or 
> less a 1:1 duplication.
> FAXSession replicates the functionality of fax show session. Output is 
> slightly stripped down from the CLI variant in order to keep things 
> consistent across multiple FAX modules and not just spandsp.
> FAXStats replicates the functionality of fax show stats, but only provides 
> the fields that res_fax would normally provide in fax show stats and not any 
> of the technology specific fields.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_fax_spandsp.c 417916 
>   /trunk/res/res_fax.exports.in 417916 
>   /trunk/res/res_fax.c 417916 
>   /trunk/include/asterisk/res_fax.h 417916 
>   /trunk/CHANGES 417916 
> 
> Diff: https://reviewboard.asterisk.org/r/3666/diff/
> 
> 
> Testing
> -------
> 
> Created some simple transmit/receive fax sessions by originating calls 
> to/from faxsend/faxreceive extensions and then ran each of these commands.
> Did the above with and without action_id included to make sure it would be 
> reproduced across events and responses.
> Checked the output of documentation for events and actions for sanity.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to