----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/#review12811 -----------------------------------------------------------
Ship it! branches/12/res/stasis/control.c <https://reviewboard.asterisk.org/r/3729/#comment23145> The use of ao2_container_count() assumes nobody else can get access to the container to add more commands. This isn't theoretically true since the container is still obtainable from the channel datastore. It's a good thing nothing cares about this return value. The way you had it counting each command executed before will always give you the number of commands actually executed. - rmudgett On July 21, 2014, 4:55 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3729/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 4:55 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23941 > https://issues.asterisk.org/jira/browse/ASTERISK-23941 > > > Repository: Asterisk > > > Description > ------- > > This allows commands to be queued in a channel datastore to be executed upon > a channel entering Stasis(). This functionality is only available from > components of res_stasis.so. This functionality is required to get a > redirected channel back into the bridge for which it was destined due to the > attended transfer. > > > Diffs > ----- > > branches/12/res/stasis/control.c 419109 > branches/12/res/stasis/control.h 419109 > branches/12/res/stasis/command.c 419109 > branches/12/res/stasis/command.h 419109 > branches/12/res/res_stasis.c 419109 > > Diff: https://reviewboard.asterisk.org/r/3729/diff/ > > > Testing > ------- > > Tested as part of the complete solution to ASTERISK-23941. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
