----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12858 -----------------------------------------------------------
trunk/include/asterisk/stasis.h <https://reviewboard.asterisk.org/r/3823/#comment23219> I'm not a big fan of ternary return values. I'd change this to be an enum. trunk/main/stasis_channels.c <https://reviewboard.asterisk.org/r/3823/#comment23221> There are lots of other places where the message types are called without first checking if the message type is available. For example: app_agent_pool:send_agent_login|send_agent_logoff app_chanspy:publish_chanspy_message etc. Generally, any function that unilaterally would construct a message needs to first see if its type is available. - Matt Jordan On July 21, 2014, 4:39 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3823/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 4:39 p.m.) > > > Review request for Asterisk Developers and Corey Farrell. > > > Repository: Asterisk > > > Description > ------- > > This introduces stasis.conf and a mechanism to prevent certain message types > from being published. > > > Diffs > ----- > > trunk/tests/test_stasis_channels.c 419109 > trunk/tests/test_stasis.c 419109 > trunk/main/stasis_message.c 419109 > trunk/main/stasis_channels.c 419109 > trunk/main/stasis_cache.c 419109 > trunk/main/stasis_bridges.c 419109 > trunk/main/stasis.c 419109 > trunk/include/asterisk/stasis.h 419109 > trunk/configs/samples/stasis.conf.sample PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3823/diff/ > > > Testing > ------- > > Tested by causing the stasis unittests to fail with the following stasis.conf > configuration: > [declined_message_types] > decline=TestMessage > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
