-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3866/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24124
https://issues.asterisk.org/jira/browse/ASTERISK-24124
Repository: testsuite
Description
-------
In Asterisk trunk, we introduced a regression in the AMI UserEvent command. A
code change was made that assumed that the first header being processed in the
command was the "Action:" header, and that this header should not be emitted by
Asterisk in the following UserEvent. This assumption does not hold true, and
can result in lost information in the UserEvent sent by Asterisk. The fix for
this is a two-line change in manager.c that has been provided by John Hardin.
The fix is so small it does not warrant review on its own. Since there was a
regression though, having a test to verify this does not happen again is useful.
This sends the same UserEvent command to Asterisk using several permutations of
the headers. We ensure that each results in the same information being sent in
the AMI UserEvent that Asterisk emits.
Diffs
-----
/asterisk/trunk/tests/manager/userevent/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/manager/userevent/event.py PRE-CREATION
/asterisk/trunk/tests/manager/tests.yaml 5154
Diff: https://reviewboard.asterisk.org/r/3866/diff/
Testing
-------
I can confirm that this test does not pass with current trunk, but with the
patch applied, the test passes successfully.
Thanks,
Mark Michelson
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
