----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/#review12990 -----------------------------------------------------------
/asterisk/trunk/lib/python/asterisk/ami.py <https://reviewboard.asterisk.org/r/3869/#comment23398> Is there any harm in stopping the reactor before the virtual callback, or should the stop test occur afterwards? /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3869/#comment23402> This could just be an Echo() after answer. Wait is eschewed in tests. /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf <https://reviewboard.asterisk.org/r/3869/#comment23391> red spot /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/pjsip.conf <https://reviewboard.asterisk.org/r/3869/#comment23390> red spot - Scott Griepentrog On Aug. 3, 2014, 5:58 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3869/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2014, 5:58 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24115 > https://issues.asterisk.org/jira/browse/ASTERISK-24115 > > > Repository: testsuite > > > Description > ------- > > This change adds two things: > > 1. The ability for an action to be configured for an AMI event handler. Right > now two actions are supported: "none" and "stop". If the "stop" action is > configured the test will be terminated when the minimum number of events is > received. > > 2. A test which establishes a relationship between two running Asterisk > instances and publishes device state from one to the other. The test confirms > that the second Asterisk receives all device state changes in the expected > order. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 5316 > /asterisk/trunk/tests/channels/pjsip/publish/tests.yaml PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast2/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_devicestate/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/lib/python/asterisk/ami.py 5316 > > Diff: https://reviewboard.asterisk.org/r/3869/diff/ > > > Testing > ------- > > Executed test, it passes. Sabotaged test, it fails. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
