----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3882/#review13016 -----------------------------------------------------------
trunk/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3882/#comment23439> Because the rest of the Asterisk code does it this way: instead of bitwiseOr | please, a logicalOr || see http://stackoverflow.com/questions/3154132/what-is-the-difference-between-logical-and-conditional-and-or-in-c One reason, I would use an "else if" for the EINTR case. However, I am not sure if the coding-style guides have a rule for this. @Richard I am just curious after reading the code: When is EINTR possible? Or is that just a coding convention? - Alexander Traud On Aug. 6, 2014, 2:21 a.m., ebroad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3882/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 2:21 a.m.) > > > Review request for Asterisk Developers and Alexander Traud. > > > Bugs: ASTERISK-18345 > https://issues.asterisk.org/jira/browse/ASTERISK-18345 > > > Repository: Asterisk > > > Description > ------- > > Replace sip_tls_read() and sip_tcp_read() with a single function and resolve > the poll/wait issue with large SDP payloads. See > https://reviewboard.asterisk.org/r/3653/ for the discussion on this. > > > Diffs > ----- > > trunk/channels/chan_sip.c 419821 > > Diff: https://reviewboard.asterisk.org/r/3882/diff/ > > > Testing > ------- > > Made and received calls successfully with CSipSimple with full SIP headers > over TLS, SRTP and multiple codecs enabled ensuring a large SDP payload. > > > Thanks, > > ebroad > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
