> On Aug. 22, 2012, 8:43 a.m., nixon wrote: > > I try to compile and result are... > > chan_sip.c: In function ‘register_realtime_peers_with_callbackextens’: > > chan_sip.c:4996: warning: implicit declaration of function ‘sip_unref_peer’ > > > > asterisk-1.8.16.0-rc1 > > wdoekes wrote: > nixon: This was a patch against trunk. It has even been submitted to > trunk already. > > If you try asterisk-11, this feature should be included already. > > nixon wrote: > Include this patch in *-1.8 branch please. > > Matt Jordan wrote: > New features or intrusive improvements are not made to released branches > of Asterisk. This will not go into Asterisk 1.8. You are more then welcome > to backport this feature to the 1.8 branch and maintain a patch yourself, or > a team branch in subversion. > > nixon wrote: > I have tested *-11 beta1. "sip reload" not work properly for peers with > "callbackextension". There are unregistered after sip reload. > More... after initial * start callbackextension's peers not registering > without "sip reload". :) > > Matt Jordan wrote: > Please stop commenting on this review. > > If you have valid bugs to report on a committed feature, please report > them to the issue tracker at https://issues.asterisk.org/jira.
Bug was reported at https://issues.asterisk.org/jira/browse/ASTERISK-23542 - nixon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1717/#review6945 ----------------------------------------------------------- On Feb. 7, 2012, 2:11 p.m., Terry Wilson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/1717/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2012, 2:11 p.m.) > > > Review request for Asterisk Developers and wdoekes. > > > Bugs: ASTERISK-13456 > https://issues.asterisk.org/jira/browse/ASTERISK-13456 > > > Repository: Asterisk > > > Description > ------- > > This patch is a continuation of the one on > https://reviewboard.asterisk.org/r/344/. If multiple peers are defined with > the same host/port, but differing callbackextensions, it chooses the peer > with the matching callbackextension. Since callbackextension creates an > outbound registration with the callbackextension as the Contact address, > matching an incoming request by that (in addition to the host/port) makes a > lot of sense. > > This patch also adds support for callbackextension to realtime by querying > all peers with callbackextensions on reload and adding registrations for > them. The patch on /r/344 didn't support matching realtime peers, but this > one does. > > While callbackextension certainly has its detractors, it is what we have to > work with at this time and we should make it work until we have a better > solution available. > > > Diffs > ----- > > /trunk/contrib/realtime/postgresql/realtime.sql 353913 > /trunk/channels/sip/include/sip.h 353913 > /trunk/channels/chan_sip.c 353913 > > Diff: https://reviewboard.asterisk.org/r/1717/diff/ > > > Testing > ------- > > I set up outbound registrations via differing callbackextensions for two > peers with the same host/port. I then dialed from the Asterisk box that those > peers were registered to and verified that the correct peer was matched in > each case. I tried this with realtime and non-realtime configs. > > > Thanks, > > Terry Wilson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
