----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3892/#review13053 -----------------------------------------------------------
Ship it! There's only one problem. Fix it and it's ready to be shipped. branches/12/main/stasis_bridges.c <https://reviewboard.asterisk.org/r/3892/#comment23488> Need to add ast_json_unref(out) in this off-nominal path. - Mark Michelson On Aug. 7, 2014, 7:57 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3892/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 7:57 p.m.) > > > Review request for Asterisk Developers and Mark Michelson. > > > Repository: Asterisk > > > Description > ------- > > This makes Stasis() event generation for transfer messages follow validation > rules. Currently, ast_json_null() is being used in place of omitting a key > entirely which falls afoul of these validation rules. > > > Diffs > ----- > > branches/12/main/stasis_bridges.c 420388 > > Diff: https://reviewboard.asterisk.org/r/3892/diff/ > > > Testing > ------- > > Ensured that the test which detected the validation failures now passes. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
