-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3653/
-----------------------------------------------------------
(Updated Aug. 7, 2014, 8:04 p.m.)
Status
------
This change has been discarded.
Review request for Asterisk Developers.
Bugs: ASTERISK-18345
https://issues.asterisk.org/jira/browse/ASTERISK-18345
Repository: Asterisk
Description
-------
With some large SDP, a *second* poll is required on the first part of a TLS
message.
The current code did not poll a second time because the variable need_poll was
inited with yes (1). That poll was a no-operation because there was a socket
event already (which mandates fgets without poll). In the current code, poll
returned immediately, fgets returned NULL, after_poll was yes (1), sip_tls_read
returned failed (-1), _sip_tcp_helper_thread went to cleanup, called
ast_tcptls_close_session_file, which closed the TLS connection.
The proposed patch, reads the gets the first message. If that failed, it does
poll. This fixed all large SDP issues with SIP over TLS which I faced.
I am aware there were changes committed to tcptls.c just recently (revision
415907). Anyway, let us fix this bug as well.
Diffs
-----
trunk/channels/chan_sip.c 416319
Diff: https://reviewboard.asterisk.org/r/3653/diff/
Testing
-------
Asterisk 12.3
Thanks,
Alexander Traud
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
