> On Aug. 18, 2014, 2:47 p.m., rmudgett wrote: > > branches/12/main/stasis_bridges.c, line 627 > > <https://reviewboard.asterisk.org/r/3921/diff/2/?file=66598#file66598line627> > > > > Please make this one declaration per line. > > > > json_transferer is leaked (new and pre-existing leak) > > > > json_transferee is leaked (new) > > opticron wrote: > I don't see the leaks you mention here. ast_json_pack with the 'o' > parameter specifier is reference stealing as is ast_json_object_set.
Ignore this, I see it now. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/#review13108 ----------------------------------------------------------- On Aug. 18, 2014, 1:55 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3921/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 1:55 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: Asterisk > > > Description > ------- > > When a blind transfer occurs that is forced to create a local channel pair to > satisfy the transfer request, information about the local channel pair is not > published. This adds a field to describe that channel to the blind transfer > message struct so that this information is conveyed properly to consumers of > the blind transfer message. > > This also fixes a bug in which Stasis() was unable to properly identify the > channel that was replacing an existing Stasis-controlled channel due to a > blind transfer. > > > Diffs > ----- > > branches/12/rest-api/api-docs/events.json 421326 > branches/12/res/stasis/app.c 421326 > branches/12/res/ari/ari_model_validators.c 421326 > branches/12/res/ari/ari_model_validators.h 421326 > branches/12/main/stasis_bridges.c 421326 > branches/12/main/bridge.c 421326 > branches/12/include/asterisk/stasis_bridges.h 421326 > > Diff: https://reviewboard.asterisk.org/r/3921/diff/ > > > Testing > ------- > > Verified functionality manually and updated the ARI blind transfer test to > check for these conditions. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
