----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3911/#review13115 -----------------------------------------------------------
/asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/play_file.py <https://reviewboard.asterisk.org/r/3911/#comment23565> This can be done entirely in the config since the channel ID is known and the bridge ID can be specified upon creation. /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/play_file.py <https://reviewboard.asterisk.org/r/3911/#comment23567> The focus of this test is the hangup during playback to a channel and other tests handle ensuring that events arrive in the correct order so re-verifying that functionality here is redundant. The channel and bridge deletions can be handled in the config since their IDs can be known and static for this test. /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/test-config.yaml <https://reviewboard.asterisk.org/r/3911/#comment23566> Why do these requests need delays? They're not racing and the first playback lasts longer than the second playback request's delay. - opticron On Aug. 14, 2014, 2:29 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3911/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 2:29 p.m.) > > > Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark > Michelson. > > > Bugs: ASTERISK-24147 > https://issues.asterisk.org/jira/browse/ASTERISK-24147 > > > Repository: testsuite > > > Description > ------- > > Specifically made to address the crash in ASTERISK-24147. This is a > modification of the existing test which checks playback in a bridge without > hanging up with only the minor difference that a hangup is added and the test > for the second playback finishing is removed. > > > Diffs > ----- > > > /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/rest_api/channels/playback/to_channel_in_bridge_hangup/play_file.py > PRE-CREATION > /asterisk/trunk/tests/rest_api/channels/playback/tests.yaml 5440 > > Diff: https://reviewboard.asterisk.org/r/3911/diff/ > > > Testing > ------- > > Tested with and without the patch in https://reviewboard.asterisk.org/r/3908/ > > Without the patch, Asterisk crashes and the test fails. > With the patch, the test is successful. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
