----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3925/#review13145 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Aug. 21, 2014, 10:36 a.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3925/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 10:36 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23994 > https://issues.asterisk.org/jira/browse/ASTERISK-23994 > > > Repository: Asterisk > > > Description > ------- > > From the issue, it was determined that using pj_gethostname() to populate the > origin line of SDPs is not guaranteed to meet RFC 4566's requirement that the > address be a FQDN or IP address. This changeset modifies the process by > getting the hostname and then resolving that into an IP address. On my box, I > could change the IP address by modifying my /etc/hosts file to resolve my > hostname to a different IP address. > > > Diffs > ----- > > /branches/12/res/res_pjsip_session.c 421564 > > Diff: https://reviewboard.asterisk.org/r/3925/diff/ > > > Testing > ------- > > Placed an outbound call from Asterisk. I observed that the SDP origin line > now contained an IP address instead of a hostname. When I modified /etc/hosts > to resolve the hostname to a different IP address, that IP address appeared > in the SDP origin line instead. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
