-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3873/
-----------------------------------------------------------
(Updated Aug. 21, 2014, 1:38 p.m.)
Review request for Asterisk Developers and Mark Michelson.
Changes
-------
Follow Kinsey's most recent suggestion
Bugs: ASTERISK-23870 and ASTERISK-23872
https://issues.asterisk.org/jira/browse/ASTERISK-23870
https://issues.asterisk.org/jira/browse/ASTERISK-23872
Repository: testsuite
Description
-------
Continued from: https://reviewboard.asterisk.org/r/3673/
> This changeset implements the nominal resource list tests outlined on this
> page:
> https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan
> There are six tests:
> 1. Subscription Establishment: Simply ensures that Asterisk responds with a
> 200 OK when we
> subscribe to a resource list and that the 200 OK has a Require: eventlist
> header in it.
> 2. Initial NOTIFY: Validates the initial NOTIFY body that Asterisk sends when
> subscribing
> to a resource list.
> 3. Full State: Establishes a subscription to a resource list and then changes
> the state of
> a resource. Ensures that Asterisk sends a NOTIFY with full state of the list.
> 4. Partial State: Establishes a subscription to a resource list and then
> changes the state
> of a resource. Ensures that Asterisk sends a NOTIFY with partial state, with
> only the
> state of the resource whose state was changed.
> 5. Resubscription Full State: Establishes a subscription and then
> resubscribes. Ensures
> that even though partial state is configured, the NOTIFY that Asterisk sends
> in response
> to the resubscription has full state of the list.
> 6. Termination Full State: Establishes a subscription and then terminates the
> subscription. Ensures that even though partial state is configured, the
> NOTIFY that
> Asterisk sends in response to the termination has full state of the list.
Since that review was posted, I've also added support for lists of lists and
MWI bodies to the RLSIntegrity and pcap libraries.
Diffs (updated)
-----
/asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml 5385
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/tests.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_test.py
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/rls_integrity.py
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/patch.diff
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/tests.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/tests.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/tests.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/sipp/termination.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/sipp/list_subscribe.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/subscription_establishment/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/sipp/resubscribe.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/sipp/list_subscribe.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/sipp/list_subscribe.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/sipp/list_subscribe.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pcap.py 5385
Diff: https://reviewboard.asterisk.org/r/3873/diff/
Testing
-------
I've been running the tests against mmichelson's rls-rlmi branch to ensure that
they pass when expected to pass and fail as the resource lists differ from what
is actually received. I've also written a whole set of lists of lists tests for
presence which will be covered in another review and a list test for MWI that
will be part of a separate review as well.
Thanks,
Jonathan Rose
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
