----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13162 -----------------------------------------------------------
/asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/3931/#comment23622> 1. Please use spaces, not tabs. 2. Since you use `continue`, the total test counts don't add up. I'd rather see this entire block indented in an `else:` block. (3. And while changing that, you can fix the bad indentation in the two "could not kill" if's.) /asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/3931/#comment23623> - s/print/show/;s/will/would/ - missing trailing period - wdoekes On Aug. 24, 2014, 5:44 p.m., Tzafrir Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3931/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2014, 5:44 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > Adds option -d (--dry-run) to runtests.py to just list the tests that will be > run and not actually run them. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5520 > > Diff: https://reviewboard.asterisk.org/r/3931/diff/ > > > Testing > ------- > > > Thanks, > > Tzafrir Cohen > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
