> On Aug. 25, 2014, 4:42 p.m., rmudgett wrote: > > branches/1.8/main/callerid.c, line 1013 > > <https://reviewboard.asterisk.org/r/3923/diff/3/?file=66780#file66780line1013> > > > > Where did the requirement to allow a missing > come from? The previous > > code required the <> to match. The prevous code was more lenient with the > > quotes.
It was a corner case I noticed during testing. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13174 ----------------------------------------------------------- On Aug. 25, 2014, 3:50 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3923/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 3:50 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This allows the callerid parsing function to handle malformed input strings > and strings containing escaped and unescaped double quotes. This also adds a > unittest to cover many of the cases where the parsing algorithm previously > failed. > > > Diffs > ----- > > branches/1.8/tests/test_utils.c 421975 > branches/1.8/tests/test_callerid.c PRE-CREATION > branches/1.8/main/utils.c 421975 > branches/1.8/main/callerid.c 421975 > branches/1.8/include/asterisk/utils.h 421975 > branches/1.8/channels/chan_sip.c 421975 > > Diff: https://reviewboard.asterisk.org/r/3923/diff/ > > > Testing > ------- > > Ran the unittest. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
