----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/#review13184 -----------------------------------------------------------
Ship it! Ship It! - rmudgett On Aug. 25, 2014, 8:59 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3933/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 8:59 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This allows the callerid parsing function to handle malformed input strings > and strings containing escaped and unescaped double quotes. This also adds a > unittest to cover many of the cases where the parsing algorithm previously > failed. > > This corrects a bug in the PJSIP backend that allows quoted callerid strings > to contain unescaped quotes which can cause phones to ignore INVITEs entirely. > > > Diffs > ----- > > branches/12/tests/test_utils.c 421534 > branches/12/tests/test_callerid.c PRE-CREATION > branches/12/res/res_pjsip_caller_id.c 421534 > branches/12/main/utils.c 421534 > branches/12/main/callerid.c 421534 > branches/12/include/asterisk/utils.h 421534 > branches/12/channels/chan_sip.c 421534 > > Diff: https://reviewboard.asterisk.org/r/3933/diff/ > > > Testing > ------- > > Ran the unittest and ran manual call tests. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
