----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3950/#review13189 -----------------------------------------------------------
branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23676> silly use of RAII_VAR Just ast_json_unref before returning at the end of the function. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23677> silly use of RAII_VAR Just ast_json_unref before returning at the end of the function. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23678> silly use of RAII_VAR Just ast_json_unref before returning at the end of the function. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23679> silly use of RAII_VAR Just ast_json_unref before returning at the end of the function. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23665> This is no longer used and always leaked now. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3950/#comment23675> Passing chan doesn't seem necessary since it can be obtained as user->chan just like generic_mute_unmute_user(). branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23666> s/as as/as an/ branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23667> s/as as/as an/ branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23668> s/as as/as an/ branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23669> s/as as/as an/ branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23670> s/as as/as an/ branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23671> silly use of RAII_VAR Just free before returning branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23672> silly use of RAII_VAR Just free before returning branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23673> silly use of RAII_VAR Just free before returning branches/12/apps/confbridge/confbridge_manager.c <https://reviewboard.asterisk.org/r/3950/#comment23674> silly use of RAII_VAR Just free before returning - rmudgett On Aug. 26, 2014, 8:37 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3950/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 8:37 p.m.) > > > Review request for Asterisk Developers and rmudgett. > > > Repository: Asterisk > > > Description > ------- > > Currently there's no way to tell if a user is an admin or not when receiving > the join, leave, mute, unmute and talking events. This patch adds that > capability. > > > Diffs > ----- > > branches/12/apps/confbridge/confbridge_manager.c 422108 > branches/12/apps/app_confbridge.c 422108 > > Diff: https://reviewboard.asterisk.org/r/3950/diff/ > > > Testing > ------- > > Checked that the AMI events had properly set Admin flags. > > All of the 11 eligible TestSuite confbridge tests passed although they don't > test for the existence of the new flag yet. Nothing broke at least. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev