-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3954/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: AFS-155
https://issues.asterisk.org/jira/browse/AFS-155
Repository: Asterisk
Description
-------
* Fix periodic endpoint qualify OPTIONS sched deletion race by avoiding it.
The sched entry will no longer self stop and must be externally stopped.
* Added REF_DEBUG description tags to struct sched_data in pjsip_options.c.
* Fix some off-nominal ref leaks in schedule_qualify(), qualify_and_schedule().
* Reordered pjsip_options.c module start/stop code to cleanup better on error.
Diffs
-----
/branches/13/res/res_pjsip/pjsip_options.c 422240
Diff: https://reviewboard.asterisk.org/r/3954/diff/
Testing
-------
I was not able to reproduce the reported crash, but was able to see some
problems in the code that could allow the crash to happen. Review
https://reviewboard.asterisk.org/r/3927 for ASTERISK-24212 likely reduced the
crash potential of the periodic OPTIONS endpoint qualify poll or was the reason
for the reported crash.
Set the qualify_frequency option to different values and reloaded res_pjsip
each time. The OPTIONS poll frequency changed, started, and stopped according
to the new qualify_frequency value.
Thanks,
rmudgett
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
