-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3969/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 6:24 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Address mjordan's finding.


Repository: Asterisk


Description
-------

Apparently instead of using the readperm mask, it was using the send_events 
mask... which is somewhat weird.  It's initialized to -1 (which will return 
true when used with bitwise and on EVENT_FLAG_SYSTEM) and this is where the odd 
behavior came from.

I think this was just a mistake and switching to the readperm mask appears to 
have fixed it.


Diffs (updated)
-----

  /branches/1.8/main/manager.c 422543 

Diff: https://reviewboard.asterisk.org/r/3969/diff/


Testing
-------

Ran through the login process with and without the system read permission.  
With it, I got the FullyBootted event. Without it, I did not.


Thanks,

Jonathan Rose

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to