----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3965/#review13253 -----------------------------------------------------------
Ship it! Except for a couple of missing docstrings and long lines, this looks good to go! - opticron On Sept. 1, 2014, 12:19 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3965/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 12:19 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24241 > https://issues.asterisk.org/jira/browse/ASTERISK-24241 > > > Repository: testsuite > > > Description > ------- > > This patch tests CDRs for channels in a multi-party bridge. It reproduces the > bug on ASTERISK-24241, and passes with the patch on r3964. The test: > * Makes 5 Local channels, and adds them to a multi-party bridge via ARI. > * It then takes channels 0 and 3 and removes from the bridge > * It then re-adds channels 0 and 3 > * Upon having all 5 channels back in the multi-party bridge, it removes them > all, hangs them up, and deletes the bridge. > > The test verifies that the expected CDRs are generated. > > > Diffs > ----- > > /asterisk/trunk/tests/cdr/tests.yaml 5539 > /asterisk/trunk/tests/cdr/cdr_bridge_multi/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/cdr/cdr_bridge_multi/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/cdr/cdr_bridge_multi/cdr_bridge_multi.py PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3965/diff/ > > > Testing > ------- > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
