> On Sept. 17, 2014, 4:44 p.m., Mark Michelson wrote: > > I'd like to point out that the count fix will also solve issue > > ASTERISK-24161. Just as a note, when you commit this, the testsuite test > > channels/pjsip/ami/show_endpoint will start failing in Asterisk 13 and > > trunk since that test is adjusted to deal with the incorrect ListItems > > header reported back in the EndpointDetailComplete event. If you look in > > channels/pjsip/ami/show_endpoint/test-config.yaml and scroll all the way to > > the bottom, you'll see a XXX comment there explaining the problem. Right > > now, the test expects ListItems: '6', but that should be changed to > > ListItems: '7' after this patch goes in.
This patch is only good for 12 since 13/trunk add the ContactStatusDetail event which will require a slight mod. I'll patch the testsuite when the 13/trunk patch goes up. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3998/#review13327 ----------------------------------------------------------- On Sept. 17, 2014, 5:43 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3998/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 5:43 p.m.) > > > Review request for Asterisk Developers and Kevin Harwell. > > > Bugs: 24161 and 24331 > https://issues.asterisk.org/jira/browse/24161 > https://issues.asterisk.org/jira/browse/24331 > > > Repository: Asterisk > > > Description > ------- > > When no transport is associated to an endpoint, the AMI output for > PJSIPShowEndpoint indicates an error instead of silently ignoring the missing > transport. > > This patch causes the error to appear only if a transport was specified on > the endpoint and the transport doesn't exist. It also fixes an issue with > counting the objects that were actually found. > > > Diffs > ----- > > branches/12/res/res_pjsip_endpoint_identifier_ip.c 423274 > branches/12/res/res_pjsip/pjsip_configuration.c 423274 > branches/12/res/res_pjsip/location.c 423274 > branches/12/res/res_pjsip/config_transport.c 423274 > branches/12/res/res_pjsip/config_auth.c 423274 > branches/12/include/asterisk/res_pjsip.h 423274 > > Diff: https://reviewboard.asterisk.org/r/3998/diff/ > > > Testing > ------- > > Checked the output of PJSIPShowEndpoint to make sure the error appears (or > doesn't) correctly and that ListItems is set correctly. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
