----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4013/#review13421 -----------------------------------------------------------
Ship it! Minor nits Before committing for each branch it's going into be sure to check if there are conflicts in the alembic node chain. https://wiki.asterisk.org/wiki/display/AST/Merging+alembic+scripts /branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py <https://reviewboard.asterisk.org/r/4013/#comment23945> Should add the standard license header to the file. /branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py <https://reviewboard.asterisk.org/r/4013/#comment23944> extraneous blank line - rmudgett On Sept. 23, 2014, 10:41 a.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4013/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 10:41 a.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Bugs: ASTERISK-23781 > https://issues.asterisk.org/jira/browse/ASTERISK-23781 > > > Repository: Asterisk > > > Description > ------- > > The SIP directmedia value 'outgoing' was overlooked when creating the table > and needs to be added. Unfortunately this means dropping the column and > rebuilding it with a new enum. > > > Diffs > ----- > > > /branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4013/diff/ > > > Testing > ------- > > upgraded, checked to see if I could put 'outgoing' in the directmedia column. > Downgraded, upgraded again to make sure things didn't explode. > > All on a postgres database > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
