-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4039/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 10:44 a.m.)


Review request for Asterisk Developers and Joshua Colp.


Changes
-------

Added a check to make sure the candidate list contained at least one rtcp item 
as well.


Bugs: ASTERISK-24383
    https://issues.asterisk.org/jira/browse/ASTERISK-24383


Repository: Asterisk


Description
-------

When starting ice if there is not at least one remote ice candidate with an RTP 
component asterisk will crash. This is due to an assertion in pjnath as it 
expects at least one candidate with an RTP component. Added a check to make 
sure at least one candidate contains an RTP component.


Diffs (updated)
-----

  branches/12/res/res_rtp_asterisk.c 424940 

Diff: https://reviewboard.asterisk.org/r/4039/diff/


Testing
-------

Sent asterisk a list of ice candidates containing only RTCP components (no RTP 
ones) and observed the crash.  After applying the patch ran the scenario again 
and it did not crash.


Thanks,

Kevin Harwell

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to