----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4076/#review13513 -----------------------------------------------------------
The undefined symbol warning is now gone on Asterisk startup. branches/12/include/asterisk/phoneprov.h <https://reviewboard.asterisk.org/r/4076/#comment24035> Thge? branches/12/res/res_phoneprov.c <https://reviewboard.asterisk.org/r/4076/#comment24032> make static. Should also make the following two arrays static as well. pp_user_lookup[] and pp_general_lookup[] branches/12/res/res_phoneprov.c <https://reviewboard.asterisk.org/r/4076/#comment24033> Use AST_MODPRI_CHANNEL_DEPEND instead This definitely needs to load after res_pjsip and before any other phoneprov providers such as res_pjsip_phoneprov_provider. - rmudgett On Oct. 13, 2014, 6:21 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4076/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 6:21 p.m.) > > > Review request for Asterisk Developers and rmudgett. > > > Repository: Asterisk > > > Description > ------- > > Based on feedback from Richard, I created an accessor for > res_phoneprov/ast_phoneprov_std_variable_lookup and added load priority to > AST_MODULE_INFO. > > Richard, can you test this? I don't see any difference in behavior before > and after the change. res_phoneprov has AST_MODFLAG_GLOBAL_SYMBOLS set so it > should have always been loading before res_pjsip_phoneprov_provider which > doesn't have that flag set, regardless of load priority. You can't even > modify that behavior in modules.conf. > > > Diffs > ----- > > branches/12/res/res_pjsip_phoneprov_provider.c 425404 > branches/12/res/res_phoneprov.c 425404 > branches/12/include/asterisk/phoneprov.h 425404 > > Diff: https://reviewboard.asterisk.org/r/4076/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
