----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4078/#review13521 -----------------------------------------------------------
branches/12/include/asterisk/config.h <https://reviewboard.asterisk.org/r/4078/#comment24041> Typo. The rest is probably good, but I'll leave the shipit to someone else. - wdoekes On Oct. 14, 2014, 5:13 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4078/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 5:13 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > With MALLOC_DEBUG the /main/config config_basic_ops test was causing a SEGV > while doing an ast_category_delete in an ast_category_browse loop. > Apparently this never worked but was also never tested. I removed the test, > added 2 notes to config.h indicating that it's not supported and added a few > lines of code to ast_category_delete to prevent the SEGV should someone > attempt it in the future. > > > Diffs > ----- > > branches/12/tests/test_config.c 425404 > branches/12/main/config.c 425404 > branches/12/include/asterisk/config.h 425404 > > Diff: https://reviewboard.asterisk.org/r/4078/diff/ > > > Testing > ------- > > The unit tests pass now with MALLOC_DEBUG and the manager/config testsuite > tests still passes. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
