----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13532 -----------------------------------------------------------
/trunk/res/res_pjsip_keepalive.c <https://reviewboard.asterisk.org/r/4084/#comment24061> If this will only ever apply to connection oriented transports, and only has a single option, it feels like this could be part of the [global] section. Having a separate object with a single option feels like overkill. Even if this could eventually be applied to connectionless transports - such as sending STUN keep-alives if the transport is UDP - it still feels like this would be a global setting or an endpoint setting, and doesn't quite warrant its own object. - Matt Jordan On Oct. 15, 2014, 1:08 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4084/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 1:08 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Reusing connections is a good thing(tm). In the case of NAT it means that you > have an actual way to exchange data back and forth. In practice, however, > some things (such as PJSIP) close down the TCP connection after a short > period of time (in the case of PJSIP for UAC it's 33 seconds). While PJSIP > has a built in keepalive mechanism this is by default set to 90 seconds and > can only be controlled at compile time. > > The attached module implements its own keepalive which is configurable at > runtime and does not require configuration. This sends a lightweight > keepalive to keep the TCP (or TLS) connection open. > > > Diffs > ----- > > /trunk/res/res_pjsip_keepalive.c PRE-CREATION > /trunk/configs/samples/pjsip.conf.sample 425216 > > Diff: https://reviewboard.asterisk.org/r/4084/diff/ > > > Testing > ------- > > Configured keepalives and used wireshark to verify that at the specific > interval the message went out. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
