----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4083/#review13565 -----------------------------------------------------------
Ship it! Minor nit below. /asterisk/trunk/lib/python/asterisk/sippversion.py <https://reviewboard.asterisk.org/r/4083/#comment24089> Please add a space to 'SIPp ' here. Since you're silently assuming it's a space by trimming 5 characters. - wdoekes On Oct. 16, 2014, 9:41 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4083/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 9:41 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > When a core dump occurs, if the test path started with t, e, or s, those > characters would get stripped out from the path created to store the > backtrace file. This is due to incorrect usage of lstrip, which removes all > instances of any of the provided characters from the start of the string > regardless of the order: > > >>> print 'tests/something'.lstrip('tests/') > omething > > This patch changes lstrip to replace in several places, where the intent was > clearly to remove only an exact string from another. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5730 > /asterisk/trunk/lib/python/asterisk/sippversion.py 5730 > > Diff: https://reviewboard.asterisk.org/r/4083/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
