> On Oct. 10, 2014, 6:57 p.m., Corey Farrell wrote: > > /asterisk/trunk/runtests.py, line 159 > > <https://reviewboard.asterisk.org/r/4038/diff/2/?file=67974#file67974line159> > > > > Per IRC discussion with mjordan this is not always the correct location > > of refcounter.py. Update will follow to find refcounter.py and skip > > processing if it's not found. > > Scott Griepentrog wrote: > Would it not be easier just to include a copy of refcounter.py in > lib/python/asterisk and make a note in it's header to remind devs to update > the testsuite copy after any change?
NO! Two reasons: 1. utils/extconf.c and the related mess. 2. The refcounter utility clearly belongs with the version of asterisk. If the reflog output changes in a version of asterisk, the refcounter utility follows. - wdoekes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13489 ----------------------------------------------------------- On Oct. 10, 2014, 4:44 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4038/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 4:44 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24379 > https://issues.asterisk.org/jira/browse/ASTERISK-24379 > > > Repository: testsuite > > > Description > ------- > > This causes any test that leaks references to fail if REF_DEBUG is enabled. > > Additionally run-local is modified to allow REF_DEBUG to be enabled through > setup: > MENUSELECT_OPTIONS='--enable REF_DEBUG' ./run-local setup > > Note if this option is used with Asterisk 1.8 all tests will fail due to > manager.c leaking the sessions container. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5649 > /asterisk/trunk/run-local 5649 > > Diff: https://reviewboard.asterisk.org/r/4038/diff/ > > > Testing > ------- > > Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 > applied. Test fails without, passes with. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
