----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4100/#review13585 -----------------------------------------------------------
I'm not sure this should go in as it is. I think it is better to remove the dependency on core_src_codec and core_dst_codec in codec_dahdi. I have another patch I've worked up, just finding the best place to post it. - Shaun Ruffell On Oct. 21, 2014, 4:11 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4100/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 4:11 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24435 > https://issues.asterisk.org/jira/browse/ASTERISK-24435 > > > Repository: Asterisk > > > Description > ------- > > Codec_dahdi is the only translator that uses the struct > ast_translator->core_src_codec and struct ast_translator->core_dst_codec > pointers. Unfortunately, nothing ever initialized the pointers. > > > Diffs > ----- > > /branches/13/main/translate.c 426078 > /branches/13/include/asterisk/translate.h 426078 > /branches/13/codecs/codec_dahdi.c 426078 > > Diff: https://reviewboard.asterisk.org/r/4100/diff/ > > > Testing > ------- > > Made some calls that perform translation. No crashes happened. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
