----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4125/#review13615 -----------------------------------------------------------
Ship it! One more queue_unref(q) needed and this should be good to go. /branches/11/apps/app_queue.c <https://reviewboard.asterisk.org/r/4125/#comment24128> Glancing at the nearby code I noticed another leak. - Kevin Harwell On Oct. 28, 2014, 11:52 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4125/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 11:52 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24466 > https://issues.asterisk.org/jira/browse/ASTERISK-24466 > > > Repository: Asterisk > > > Description > ------- > > set_member_value has a couple leaks to references in the variable q found > through testsuite tests/queues/set_penalty. > > This change also removes the REF_DEBUG_ONLY_QUEUES compiler declaration, this > is no longer possible with the updated REF_DEBUG code. > > > Diffs > ----- > > /branches/11/apps/app_queue.c 426569 > > Diff: https://reviewboard.asterisk.org/r/4125/diff/ > > > Testing > ------- > > All tests/queues/set_penalty no longer leaks any references (verifies first > added queue_unref). > > I'm unsure if the second added queue_unref has been tested, but seems like it > is needed. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
