----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4122/#review13631 -----------------------------------------------------------
Ship it! The test originally needed the 50 iterations to be sure to catch the fault, but as it's just checking for a specific regression 5 will do fine. - Scott Griepentrog On Oct. 29, 2014, 6:27 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4122/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 6:27 a.m.) > > > Review request for Asterisk Developers and Scott Griepentrog. > > > Repository: testsuite > > > Description > ------- > > In some configurations 3 seconds is not enough of a delay before Asterisk is > fully booted, preventing "core restart gracefully" from succeeding. This > causes many iterations to be skipped, and in some cases the test never ends. > > Make use of "core waitfullybooted" to delay restarts. Remove unused global > variables workingdir and testdir, add global variable restart_iterations to > specify 50 runs. Decrease reactor_timeout from 300 to 30, use reset_timeout > instead. > > > Diffs > ----- > > /asterisk/trunk/tests/pbx/dialplan_reload/run-test 5803 > > Diff: https://reviewboard.asterisk.org/r/4122/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
