-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4103/#review13636
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Harwell


On Oct. 22, 2014, 11:06 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4103/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 11:06 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when musiconhold is started or stopped in PJSIP it is always 
> locally generated using res_musiconhold. This change adds an option, 
> moh_passthrough, that allows musiconhold requests to be passed through 
> chan_pjsip. This is done by sending a re-INVITE with recvonly state on the 
> streams when the channel is put on hold and sending a re-INVITE with sendrecv 
> state on the streams when the channel is taken off hold. The end result of 
> this being that an upstream entity (such as another PBX) can generate the 
> musiconhold instead.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_sdp_rtp.c 426095 
>   /trunk/res/res_pjsip/pjsip_configuration.c 426095 
>   /trunk/res/res_pjsip.c 426095 
>   /trunk/include/asterisk/res_pjsip_session.h 426095 
>   /trunk/include/asterisk/res_pjsip.h 426095 
>   
> /trunk/contrib/ast-db-manage/config/versions/339e1dfa644d_add_moh_passthrough_option_to_pjsip.py
>  PRE-CREATION 
>   /trunk/channels/pjsip/dialplan_functions.c 426095 
>   /trunk/channels/chan_pjsip.c 426095 
> 
> Diff: https://reviewboard.asterisk.org/r/4103/diff/
> 
> 
> Testing
> -------
> 
> Enabled option. Placed call to a remote server. Put call on hold and off 
> hold. Confirmed re-INVITEs were sent with proper state.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to