-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4164/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-24514
    https://issues.asterisk.org/jira/browse/ASTERISK-24514


Repository: Asterisk


Description
-------

When using a non-default sorcery wizard (in this instance realtime) for 
outbound registrations and after adding in an appropriate call to 
ast_sorcery_apply_config() (since it is missing) Asterisk will crash after a 
stack overflow occurs due to the code infinitely recursing.  The fix entails 
removing the outbound registration state dependency from the outbound 
registration sorcery object and instead keeping an in memory container that can 
be used to lookup the state when needed.


Diffs
-----

  branches/12/res/res_pjsip_outbound_registration.c 427675 

Diff: https://reviewboard.asterisk.org/r/4164/diff/


Testing
-------

On top of running the current testsuite tests I also manually tested various 
configurations and scenarios using a static configuration file as well as 
dynamic realtime.  Verified that the crash no longer occurs and the potentially 
affected functionality works as expected (for instance, cli/ami commands, 
module [re]loading, and manual unregistration).


Thanks,

Kevin Harwell

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to