> On Nov. 14, 2014, 9:30 a.m., Mark Michelson wrote: > > This review has been shipped. I wrote the feature against trunk, but I'm > > curious if 13's proposed policy would allow for such a change to be added > > to it as well. Thoughts?
It would, and I think this should be fine for 13. It's a relatively small addition, a useful feature, and has tests. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4167/#review13767 ----------------------------------------------------------- On Nov. 12, 2014, 12:32 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4167/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 12:32 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > There have been complaints about the fact that when a DTMF transfer is > initiated, and an incorrect number is dialled, the prompt says "Please try > again" but then doesn't give the transferer a chance to do so without > re-initiating the transfer. > > This patch adds a features.conf option called "transferdialattempts" (yes, > the name is gross, but it fits in with the convention of other options in > features.conf). This option controls how many attempts a transferer has to > dial a valid extension before being booted back out to the call with the > transferee. The option defaults to 3. As with other options from > features.conf, this can also be set using the FEATURE() dialplan function so > that it may be changed per-call if desired. > > > Diffs > ----- > > /trunk/main/features_config.c 427676 > /trunk/main/bridge_basic.c 427676 > /trunk/include/asterisk/features_config.h 427676 > > Diff: https://reviewboard.asterisk.org/r/4167/diff/ > > > Testing > ------- > > See /r/4168 > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
