> On Nov. 5, 2014, 1:55 p.m., Joshua Colp wrote:
> > I'm fine with putting this in after looking at how it impacts behavior and
> > real-world use. If you would like to fix the error that Jeremy mentioned
> > feel free to. If you would like to also make an addition to the 'CHANGES'
> > file that would be appreciated but not required. If not I'll take care of
> > it upon commit in a few days (just giving time for anyone else to chime in).
> >
> > I also apologize for how long this has taken. We strive for better but
> > don't always hit where we want to be.
ha, i missed the approval. Sorry that i did not fixed the typo and did not
pushed anything to CHANGES.
About the patch there is problem i explained above.
The problem with second version is that if you have dtls set in
general("dtlsenable=yes") and you have peer that has no DTLS configuration at
all (mostly important no "dtlsenable=no") it would set this peer as dtls
enabled one as it sets all default dtls configs for peer. from general. So
basically the first version where i set settings one by one is better one, as
it would use default settings only if peer has "dtlsenable=yes" and has no
other settings.
If we want to compare to TLS, setting TLS enabled in general does not force all
peers to be TLS enabled.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3867/#review13689
-----------------------------------------------------------
On Nov. 15, 2014, 4:31 p.m., Michael K. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3867/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2014, 4:31 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-24128
> https://issues.asterisk.org/jira/browse/ASTERISK-24128
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Load default dtls settings from [general settings]
> If peer has dtls enabled but misses some of the settings and they are set in
> default settings it would load them from there.
> It would be logical as most of sip settings work like that and as well as
> there is no way to use template in realtime and it would lead to copy paste
> same settings for every peer.
>
>
> Diffs
> -----
>
> trunk/channels/chan_sip.c 419849
>
> Diff: https://reviewboard.asterisk.org/r/3867/diff/
>
>
> Testing
> -------
>
> Test on development server (ast 11.11.0)
>
>
> Thanks,
>
> Michael K.
>
>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
