-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4201/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 9:56 a.m.)
Review request for Asterisk Developers.
Summary (updated)
-----------------
app_record: prevent stripping 1/4 second audio when channel is hung up to end
recording.
Bugs: ASTERISK-24530
https://issues.asterisk.org/jira/browse/ASTERISK-24530
Repository: Asterisk
Description
-------
We are encountering a problem recording using the Record app with 'k' option,
and hanging up to end the recording, as Asterisk is stripping 1/4 second from
the end. This is breaking some of our automated tests which record/playback
audio and so on.
It is not clear why this stripping is done but the best guess seems to be
related to stripping DTMF tones, as it is NOT done if the recording is ended by
timeout, and the code pre-dates the 'k' option.
This patch should maintain existing behaviour for DTMF termination and
timeouts, but prevent stripping in the 'hangup' case.
Diffs
-----
/trunk/apps/app_record.c 428525
Diff: https://reviewboard.asterisk.org/r/4201/diff/
Testing
-------
Our in-house automated tests which compare audio are much happier with this
patch. No problems observed with DTMF termination of recordings either.
To clarify we have tested this on 11.9.0, I have submitted the patch against
trunk, it applies to either.
Thanks,
Ben Smithurst
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
