----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4232/#review13925 -----------------------------------------------------------
Ship it! Ship It! - opticron On Dec. 8, 2014, 9:38 a.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4232/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 9:38 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24554 > https://issues.asterisk.org/jira/browse/ASTERISK-24554 > > > Repository: testsuite > > > Description > ------- > > This adds two tests to the testsuite to ensure that connected line events are > emitted when the connected line on the channel changes. > > In tests/manager/connected_line, a channel places a call to an extension that > uses the CONNECTEDLINE() dialplan function to change connected line > information. We ensure that an AMI NewConnectedLine event is emitted and that > it has the expected values for connected line name and number. > > In tests/rest_api/channels/connected_line, a channel calls a Stasis > application. When the channel enters Stasis, the Stasis application updates > the connected line on the channel using the CONNECTEDLINE() dialplan > function. We ensure that a ChannelConnectedLine event is emitted and that the > connected line name and number have the expected values. > > > Diffs > ----- > > /asterisk/trunk/tests/rest_api/channels/tests.yaml 5983 > > /asterisk/trunk/tests/rest_api/channels/connected_line_update/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/rest_api/channels/connected_line_update/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/manager/tests.yaml 5983 > /asterisk/trunk/tests/manager/connected_line/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/manager/connected_line/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4232/diff/ > > > Testing > ------- > > The tests pass. In addition, I tested for false positives by removing the > calls to the CONNECTEDLINE() dialplan function and ensuring that the tests > fail due to the events not being emitted. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
