----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4266/#review13965 -----------------------------------------------------------
Ship it! Minor comments below. ./tests/channels/pjsip/dtmf_incompatible/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/4266/#comment24485> This shouldn't be necessary. ./tests/channels/pjsip/dtmf_incompatible/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/4266/#comment24484> Add empty parens at the end of the line. - opticron On Dec. 15, 2014, 4:56 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4266/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 4:56 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24459 > https://issues.asterisk.org/jira/browse/ASTERISK-24459 > > > Repository: testsuite > > > Description > ------- > > Checks to make sure that if two pjsip endpoints with incompatible DTMF modes > are connected the appropriate bridge type is chosen. > > Note: the parent directory's tests.yaml has been modified to include this > test, but for some reason reviewboard "couldn't find the revision" or > something so it has not been included here, but will be committed. > > > Diffs > ----- > > ./tests/channels/pjsip/dtmf_incompatible/test-config.yaml PRE-CREATION > ./tests/channels/pjsip/dtmf_incompatible/sipp/invite_recv.xml PRE-CREATION > ./tests/channels/pjsip/dtmf_incompatible/sipp/invite.xml PRE-CREATION > ./tests/channels/pjsip/dtmf_incompatible/configs/ast1/pjsip.conf > PRE-CREATION > ./tests/channels/pjsip/dtmf_incompatible/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4266/diff/ > > > Testing > ------- > > Ran test without patch it failed, ran with patch it passed. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
